Fix for issue #94 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronzi
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Thank you for the fix. I would advise against dynamically calculating the max-height based on the screen height. This could cause potential issues on mobile for example. My suggestion would be to use a static px value. Something around 300px would probably work very well.
aaronzi
requested changes
Nov 12, 2024
|
AASX for testing purpose.zip for realisation of proposal: #89 (comment) |
aaronzi
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Max height for asset thumbnail is set to 30% of the document height.
Related Issue
Closes #94
Closes #89
BaSyx Configuration for Testing
https://github.com/eclipse-basyx/basyx-java-server-sdk/tree/main/examples/BaSyxMinimal